Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Unified Diff: test/cctest/test-log.cc

Issue 115760: Disable crashing ProfLazyMode test on ARM. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-log.cc
diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc
index 3d5d5ae8903524486b0212998a0dc2e81ba1afb0..e5d31e67d5bb3aa65befc69e46cd88e71bdf1d57 100644
--- a/test/cctest/test-log.cc
+++ b/test/cctest/test-log.cc
@@ -129,6 +129,11 @@ static void CompileAndRunScript(const char *src) {
}
+// Exclude the following test from ARM because profiling can
+// malfunction there.
+// TODO(mikhail.naganov): Fix it.
+#ifndef V8_TARGET_ARCH_ARM
+
namespace v8 {
namespace internal {
@@ -238,6 +243,8 @@ TEST(ProfLazyMode) {
i::FLAG_prof_auto = saved_prof_auto;
}
+#endif // V8_TARGET_ARCH_ARM
+
static inline bool IsStringEqualTo(const char* r, const char* s) {
return strncmp(r, s, strlen(r)) == 0;
@@ -701,5 +708,4 @@ TEST(EquivalenceOfLoggingAndTraversal) {
i::FLAG_always_compact = saved_always_compact;
}
-
#endif // ENABLE_LOGGING_AND_PROFILING
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698