Issue 115759: Show Unicode IDNs for "On startup" setting and "Add page" dialog for it....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115759: Show Unicode IDNs for "On startup" setting and "Add page" dialog for it.... (Closed)

Created:
11 years, 7 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
brettw, jungshik at Google

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Show Unicode IDNs for "On startup" setting and "Add page" dialog for it. TEST=visit an IDN URL, and open the "Basics" tab of the "Options" dialog, select "Open the following pages", press "Add..." button, select the IDN URL, and confirm that the URL field is shown in Unicode, or paste a Punycode URL to the URL field of the "Add page" dialog, press "Add" button, and confirm that the "Open the followig pages" list shows the Unicode URL. BUG=3991 Landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16974

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	chrome/browser/views/options/general_page_view.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/views/shelf_item_dialog.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

11 years, 7 months ago (2009-05-27 16:11:53 UTC) #5

Checked in ( http://src.chromium.org/viewvc/chrome?view=rev&revision=16974 )
Thank you.

On 2009/05/27 00:44:22, Kent wrote:
> Thank you.
> Would you commit this please?

Expand Messages | Collapse Messages