Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/ia32/assembler-ia32.h

Issue 115756: Split nested namespaces declaration in two lines in accordance with C++ Style Guide. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 19 matching lines...) Expand all
30 30
31 // The original source code covered by the above license above has been 31 // The original source code covered by the above license above has been
32 // modified significantly by Google Inc. 32 // modified significantly by Google Inc.
33 // Copyright 2006-2008 the V8 project authors. All rights reserved. 33 // Copyright 2006-2008 the V8 project authors. All rights reserved.
34 34
35 // A light-weight IA32 Assembler. 35 // A light-weight IA32 Assembler.
36 36
37 #ifndef V8_IA32_ASSEMBLER_IA32_H_ 37 #ifndef V8_IA32_ASSEMBLER_IA32_H_
38 #define V8_IA32_ASSEMBLER_IA32_H_ 38 #define V8_IA32_ASSEMBLER_IA32_H_
39 39
40 namespace v8 { namespace internal { 40 namespace v8 {
41 namespace internal {
41 42
42 // CPU Registers. 43 // CPU Registers.
43 // 44 //
44 // 1) We would prefer to use an enum, but enum values are assignment- 45 // 1) We would prefer to use an enum, but enum values are assignment-
45 // compatible with int, which has caused code-generation bugs. 46 // compatible with int, which has caused code-generation bugs.
46 // 47 //
47 // 2) We would prefer to use a class instead of a struct but we don't like 48 // 2) We would prefer to use a class instead of a struct but we don't like
48 // the register initialization to depend on the particular initialization 49 // the register initialization to depend on the particular initialization
49 // order (which appears to be different on OS X, Linux, and Windows for the 50 // order (which appears to be different on OS X, Linux, and Windows for the
50 // installed versions of C++ we tried). Using a struct permits C-style 51 // installed versions of C++ we tried). Using a struct permits C-style
(...skipping 805 matching lines...) Expand 10 before | Expand all | Expand 10 after
856 private: 857 private:
857 Assembler* assembler_; 858 Assembler* assembler_;
858 #ifdef DEBUG 859 #ifdef DEBUG
859 int space_before_; 860 int space_before_;
860 #endif 861 #endif
861 }; 862 };
862 863
863 } } // namespace v8::internal 864 } } // namespace v8::internal
864 865
865 #endif // V8_IA32_ASSEMBLER_IA32_H_ 866 #endif // V8_IA32_ASSEMBLER_IA32_H_
OLDNEW
« src/accessors.h ('K') | « src/heap-inl.h ('k') | src/ia32/assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698