Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 115752: For "Copy link address" context menu, copy the URL with Unicode host name ins... (Closed)

Created:
11 years, 7 months ago by tkent
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, tkent_google.com
Visibility:
Public.

Description

For "Copy link address" context menu, copy the URL with Unicode host name instead of Punycode host name. TEST="Copy link address" copies Unicode host name for both of <a href="punycode URL"> and <a href="Unicode URL"> if Accept-Language preference is matched. BUG=4008

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 14 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent_google.com
11 years, 7 months ago (2009-05-25 08:14:38 UTC) #1
brettw
LGTM http://codereview.chromium.org/115752/diff/1/2 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/115752/diff/1/2#newcode651 Line 651: // Unescaping path and query is not ...
11 years, 7 months ago (2009-05-26 16:22:06 UTC) #2
jungshik at Google
LGTM with Brett's concern addressed.
11 years, 7 months ago (2009-05-26 16:29:20 UTC) #3
tkent_google.com
Thanks. Would you commit this patch please? http://codereview.chromium.org/115752/diff/1/2 File chrome/browser/tab_contents/render_view_context_menu.cc (right): http://codereview.chromium.org/115752/diff/1/2#newcode651 Line 651: // ...
11 years, 7 months ago (2009-05-27 00:43:12 UTC) #4
jungshik at Google
On 2009/05/27 00:43:12, Kent wrote: > Thanks. Would you commit this patch please? Sure. I'll ...
11 years, 7 months ago (2009-05-27 01:40:00 UTC) #5
jungshik at Google
11 years, 7 months ago (2009-05-27 16:13:21 UTC) #6
On 2009/05/27 01:40:00, Jungshik Shin wrote:

> Sure. I'll after getting back the try bot results (I just sent the patch to
the

Checked in : http://src.chromium.org/viewvc/chrome?view=rev&revision=16973

Powered by Google App Engine
This is Rietveld 408576698