Issue 115751: Update webkit to r44122...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115751: Update webkit to r44122... (Closed)

Created:
11 years, 7 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
ukai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update webkit to r44123 This required dealing with a few changes in WebKit: 1- ImageBuffer::create() now returns a PassOwnPtr instead of an auto_ptr. 2- ChromeClient::createHTMLParserQuirks() now returns a PassOwnPtr instead of a raw pointer. 3- HTMLFormControlElement::onChange was renamed dispatchFormControlChangeEvent. 4- dom/SelectElement.{h,cpp} were added to the tree. TEST=none R=ukai BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16849

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -17 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/chrome_client_impl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/dom_operations.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/password_autocomplete_listener.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/webcore_unit_tests/TransparencyWin_unittest.cpp	View	1	12 chunks	+12 lines, -12 lines	0 comments	Download
M	webkit/webkit.gyp	View	1	4 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

Updated to pull webkit @44123 so that it includes my webkit change to fix TransparencyWin.cpp ...

11 years, 7 months ago (2009-05-25 07:19:08 UTC) #2

LGTM

Expand Messages | Collapse Messages