Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: chrome/browser/gtk/download_item_gtk.h

Issue 115740: Move download shelf from per-tab to per-window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.cc ('k') | chrome/browser/gtk/download_item_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/download_item_gtk.h
===================================================================
--- chrome/browser/gtk/download_item_gtk.h (revision 17483)
+++ chrome/browser/gtk/download_item_gtk.h (working copy)
@@ -11,6 +11,7 @@
#include "base/scoped_ptr.h"
#include "chrome/browser/download/download_manager.h"
#include "chrome/browser/icon_manager.h"
+#include "chrome/common/owned_widget_gtk.h"
class BaseDownloadItemModel;
class DownloadShelfContextMenuGtk;
@@ -26,8 +27,7 @@
DownloadItemGtk(DownloadShelfGtk* parent_shelf,
BaseDownloadItemModel* download_item_model);
- // We put |hbox_| in |parent_shelf| and rely on |parent_shelf| recursively
- // destroying its children. Hence we do nothing in the destructor.
+ // Destroys all widgets belonging to this DownloadItemGtk.
~DownloadItemGtk();
// DownloadItem::Observer implementation.
@@ -109,11 +109,11 @@
DownloadShelfGtk* parent_shelf_;
// The widget that contains the body and menu dropdown.
- GtkWidget* hbox_;
+ OwnedWidgetGtk hbox_;
// The widget that contains the name of the download and the progress
// animation.
- GtkWidget* body_;
+ OwnedWidgetGtk body_;
// The GtkLabel that holds the download title text.
GtkWidget* name_label_;
@@ -130,7 +130,7 @@
// The widget that contains the animation progress and the file's icon
// (as well as the complete animation).
- GtkWidget* progress_area_;
+ OwnedWidgetGtk progress_area_;
// In degrees. Only used for downloads with no known total size.
int progress_angle_;
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.cc ('k') | chrome/browser/gtk/download_item_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698