Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Issue 115740: Move download shelf from per-tab to per-window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc
===================================================================
--- chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (revision 17483)
+++ chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc (working copy)
@@ -68,11 +68,8 @@
// Make sure the download shelf is not showing.
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
- scoped_refptr<TabProxy> dl_tab(browser->GetTab(0));
- ASSERT_TRUE(dl_tab.get());
-
bool visible = false;
- ASSERT_TRUE(dl_tab->IsShelfVisible(&visible));
+ ASSERT_TRUE(browser->IsShelfVisible(&visible));
EXPECT_FALSE(visible);
}
@@ -155,10 +152,12 @@
EXPECT_FALSE(timed_out);
// Check that the new page got loaded, and that no download was triggered.
- bool shelf_is_visible = false;
EXPECT_TRUE(tab->GetTabTitle(&tab_title));
- EXPECT_TRUE(tab->IsShelfVisible(&shelf_is_visible));
EXPECT_EQ(L"Title Of Awesomeness", tab_title);
+
+ bool shelf_is_visible = false;
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ EXPECT_TRUE(browser->IsShelfVisible(&shelf_is_visible));
EXPECT_FALSE(shelf_is_visible);
}
« no previous file with comments | « chrome/browser/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698