Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: chrome/browser/download/save_page_uitest.cc

Issue 115740: Move download shelf from per-tab to per-window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/save_package.cc ('k') | chrome/browser/gtk/browser_window_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_uitest.cc
===================================================================
--- chrome/browser/download/save_page_uitest.cc (revision 17483)
+++ chrome/browser/download/save_page_uitest.cc (working copy)
@@ -85,7 +85,8 @@
EXPECT_TRUE(tab->SavePage(full_file_name.ToWStringHack(), dir.ToWStringHack(),
SavePackage::SAVE_AS_ONLY_HTML));
- EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get()));
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));
CheckFile(full_file_name, FilePath::FromWStringHack(UTF8ToWide(file_name)),
true);
@@ -105,7 +106,8 @@
EXPECT_TRUE(tab->SavePage(full_file_name.ToWStringHack(), dir.ToWStringHack(),
SavePackage::SAVE_AS_COMPLETE_HTML));
- EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get()));
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));
CheckFile(dir.AppendASCII("1.png"), FilePath(FILE_PATH_LITERAL("1.png")),
true);
@@ -128,7 +130,8 @@
EXPECT_FALSE(tab->SavePage(full_file_name.ToWStringHack(),
dir.ToWStringHack(),
SavePackage::SAVE_AS_ONLY_HTML));
- EXPECT_FALSE(WaitForDownloadShelfVisible(tab.get()));
+ scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
+ EXPECT_FALSE(WaitForDownloadShelfVisible(browser.get()));
}
TEST_F(SavePageTest, FilenameFromPageTitle) {
@@ -148,7 +151,7 @@
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
automation()->SavePackageShouldPromptUser(false);
EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE));
- EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get()));
+ EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));
automation()->SavePackageShouldPromptUser(true);
CheckFile(dir.AppendASCII("1.png"), FilePath(FILE_PATH_LITERAL("1.png")),
@@ -180,7 +183,7 @@
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
automation()->SavePackageShouldPromptUser(false);
EXPECT_TRUE(browser->RunCommandAsync(IDC_SAVE_PAGE));
- EXPECT_TRUE(WaitForDownloadShelfVisible(tab.get()));
+ EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));
automation()->SavePackageShouldPromptUser(true);
CheckFile(full_file_name, FilePath::FromWStringHack(UTF8ToWide(file_name)),
« no previous file with comments | « chrome/browser/download/save_package.cc ('k') | chrome/browser/gtk/browser_window_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698