Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3371)

Unified Diff: chrome/browser/views/frame/browser_view.h

Issue 115740: Move download shelf from per-tab to per-window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/download_shelf_view.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/frame/browser_view.h
===================================================================
--- chrome/browser/views/frame/browser_view.h (revision 17483)
+++ chrome/browser/views/frame/browser_view.h (working copy)
@@ -28,6 +28,7 @@
class Browser;
class BrowserBubble;
class BrowserToolbarView;
+class DownloadShelfView;
class EncodingMenuControllerDelegate;
class ExtensionShelf;
class FullscreenExitBubble;
@@ -215,6 +216,9 @@
virtual void ShowAboutChromeDialog();
virtual void ShowBookmarkManager();
virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked);
+ virtual void SetDownloadShelfVisible(bool visible);
+ virtual bool IsDownloadShelfVisible() const;
+ virtual DownloadShelf* GetDownloadShelf();
virtual void ShowReportBugDialog();
virtual void ShowClearBrowsingDataDialog();
virtual void ShowImportDialog();
@@ -317,12 +321,6 @@
// |contents| can be NULL.
bool MaybeShowInfoBar(TabContents* contents);
- // Prepare to show a Download Shelf for the specified TabContents. Returns
- // true if there is a Download Shelf to show and one is supported for this
- // Browser type, and there should be a subsequent re-layout to show it.
- // |contents| can be NULL.
- bool MaybeShowDownloadShelf(TabContents* contents);
-
// Updates various optional child Views, e.g. Bookmarks Bar, Info Bar or the
// Download Shelf in response to a change notification from the specified
// |contents|. |contents| can be NULL. In this case, all optional UI will be
@@ -365,7 +363,6 @@
// active_bookmark_bar_ is either NULL, if the bookmark bar isn't showing,
// or is bookmark_bar_view_ if the bookmark bar is showing.
views::View* active_bookmark_bar_;
- views::View* active_download_shelf_;
// The TabStrip.
TabStrip* tabstrip_;
@@ -376,6 +373,9 @@
// The Bookmark Bar View for this window. Lazily created.
scoped_ptr<BookmarkBarView> bookmark_bar_view_;
+ // The download shelf view (view at the bottom of the page).
+ DownloadShelfView* download_shelf_;
+
// The InfoBarContainer that contains InfoBars for the current tab.
InfoBarContainer* infobar_container_;
« no previous file with comments | « chrome/browser/views/download_shelf_view.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698