Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 115740: Move download shelf from per-tab to per-window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.h ('k') | chrome/browser/gtk/download_item_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/browser_window_gtk.cc
===================================================================
--- chrome/browser/gtk/browser_window_gtk.cc (revision 17483)
+++ chrome/browser/gtk/browser_window_gtk.cc (working copy)
@@ -18,10 +18,13 @@
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/browser.h"
#include "chrome/browser/browser_list.h"
+#include "chrome/browser/download/download_item_model.h"
+#include "chrome/browser/download/download_manager.h"
#include "chrome/browser/gtk/about_chrome_dialog.h"
#include "chrome/browser/gtk/bookmark_bar_gtk.h"
#include "chrome/browser/gtk/browser_toolbar_gtk.h"
#include "chrome/browser/gtk/clear_browsing_data_dialog_gtk.h"
+#include "chrome/browser/gtk/download_shelf_gtk.h"
#include "chrome/browser/gtk/go_button_gtk.h"
#include "chrome/browser/gtk/import_dialog_gtk.h"
#include "chrome/browser/gtk/infobar_container_gtk.h"
@@ -558,6 +561,17 @@
toolbar_->star()->ShowStarBubble(url, !already_bookmarked);
}
+bool BrowserWindowGtk::IsDownloadShelfVisible() const {
+ return download_shelf_.get() && download_shelf_->IsShowing();
+}
+
+DownloadShelf* BrowserWindowGtk::GetDownloadShelf() {
+ if (!download_shelf_.get())
+ download_shelf_.reset(new DownloadShelfGtk(browser_.get(),
+ render_area_vbox_));
+ return download_shelf_.get();
+}
+
void BrowserWindowGtk::ShowReportBugDialog() {
NOTIMPLEMENTED();
}
@@ -596,11 +610,12 @@
}
int BrowserWindowGtk::GetExtraRenderViewHeight() const {
- // The download shelf is controlled by its TabContents, so we don't have to
- // worry about it here.
int sum = infobar_container_->TotalHeightOfClosingBars();
if (bookmark_bar_->IsClosing())
sum += bookmark_bar_->GetHeight();
+ if (download_shelf_.get() && download_shelf_->IsClosing()) {
+ sum += download_shelf_->GetHeight();
+ }
return sum;
}
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.h ('k') | chrome/browser/gtk/download_item_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698