Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2903)

Unified Diff: chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Issue 115740: Move download shelf from per-tab to per-window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/tabs/tab_renderer_gtk.cc
===================================================================
--- chrome/browser/gtk/tabs/tab_renderer_gtk.cc (revision 17483)
+++ chrome/browser/gtk/tabs/tab_renderer_gtk.cc (working copy)
@@ -91,9 +91,6 @@
TabRendererGtk::TabImage TabRendererGtk::tab_hover_ = {0};
gfx::Font* TabRendererGtk::title_font_ = NULL;
int TabRendererGtk::title_font_height_ = 0;
-SkBitmap* TabRendererGtk::download_icon_ = NULL;
-int TabRendererGtk::download_icon_width_ = 0;
-int TabRendererGtk::download_icon_height_ = 0;
int TabRendererGtk::close_button_width_ = 0;
int TabRendererGtk::close_button_height_ = 0;
@@ -173,7 +170,6 @@
TabRendererGtk::TabRendererGtk()
: showing_icon_(false),
- showing_download_icon_(false),
showing_close_button_(false),
fav_icon_hiding_offset_(0),
should_display_crashed_favicon_(false),
@@ -200,7 +196,6 @@
if (!loading_only) {
data_.title = UTF16ToWideHack(contents->GetTitle());
data_.off_the_record = contents->profile()->IsOffTheRecord();
- data_.show_download_icon = contents->IsDownloadShelfVisible();
data_.crashed = contents->is_crashed();
data_.favicon = contents->GetFavIcon();
}
@@ -303,10 +298,6 @@
close_button_width_ = rb.GetBitmapNamed(IDR_TAB_CLOSE)->width();
close_button_height_ = rb.GetBitmapNamed(IDR_TAB_CLOSE)->height();
-
- download_icon_ = rb.GetBitmapNamed(IDR_DOWNLOAD_ICON);
- download_icon_width_ = download_icon_->width();
- download_icon_height_ = download_icon_->height();
}
void TabRendererGtk::SetBounds(const gfx::Rect& bounds) {
@@ -378,10 +369,8 @@
// See if the model changes whether the icons should be painted.
const bool show_icon = ShouldShowIcon();
- const bool show_download_icon = data_.show_download_icon;
const bool show_close_button = ShouldShowCloseBox();
if (show_icon != showing_icon_ ||
- show_download_icon != showing_download_icon_ ||
show_close_button != showing_close_button_)
Layout();
@@ -418,11 +407,6 @@
}
}
- if (show_download_icon) {
- canvas->DrawBitmapInt(*download_icon_,
- download_icon_bounds_.x(), download_icon_bounds_.y());
- }
-
// Paint the Title.
std::wstring title = data_.title;
if (title.empty()) {
@@ -475,15 +459,6 @@
favicon_bounds_.SetRect(local_bounds.x(), local_bounds.y(), 0, 0);
}
- // Size the download icon.
- showing_download_icon_ = data_.show_download_icon;
- if (showing_download_icon_) {
- int icon_top = kTopPadding + (content_height - download_icon_height_) / 2;
- download_icon_bounds_.SetRect(local_bounds.width() - download_icon_width_,
- icon_top, download_icon_width_,
- download_icon_height_);
- }
-
// Size the Close button.
showing_close_button_ = ShouldShowCloseBox();
if (showing_close_button_) {
@@ -518,8 +493,6 @@
} else {
title_width = std::max(local_bounds.width() - title_left, 0);
}
- if (data_.show_download_icon)
- title_width = std::max(title_width - download_icon_width_, 0);
title_bounds_.SetRect(title_left, title_top, title_width, title_font_height_);
// TODO(jhawkins): Handle RTL layout.
« no previous file with comments | « chrome/browser/gtk/tabs/tab_renderer_gtk.h ('k') | chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698