Move download shelf from per-tab to per-window

chrome/browser/download/download_file.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_file.h"
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/stl_util-inl.h"
 #include "base/string_util.h"
@@ skipping 518 matching lines @@
   DCHECK(MessageLoop::current() == file_loop_);
   platform_util::ShowItemInFolder(full_path);
 }
 
 // Launches the selected download using ShellExecute 'open' verb. For windows,
 // if there is a valid parent window, the 'safer' version will be used which can
 // display a modal dialog asking for user consent on dangerous files.
 void DownloadFileManager::OnOpenDownloadInShell(const FilePath& full_path,
                                                 const GURL& url,
                                                 gfx::NativeView parent_window) {
-  DCHECK(MessageLoop::current() == file_loop_);
-
 #if defined(OS_WIN)
-  if (NULL != parent_window) {
-    win_util::SaferOpenItemViaShell(parent_window, L"", full_path,
-                                    UTF8ToWide(url.spec()));
-    return;
-  }
+    DCHECK(MessageLoop::current() == file_loop_);
+    if (NULL != parent_window) {
+      win_util::SaferOpenItemViaShell(parent_window, L"", full_path,
+                                      UTF8ToWide(url.spec()));
+    } else {
+      win_util::OpenItemViaShell(full_path);
+    }
+#else
+  // TODO(port) implement me.
+  NOTIMPLEMENTED();
 #endif
-
-  platform_util::OpenItem(full_path);
 }
 
 // The DownloadManager in the UI thread has provided a final name for the
 // download specified by 'id'. Rename the in progress download, and remove it
 // from our table if it has been completed or cancelled already.
 void DownloadFileManager::OnFinalDownloadName(int id,
                                               const FilePath& full_path,
                                               DownloadManager* manager) {
   DCHECK(MessageLoop::current() == file_loop_);
   DownloadFileMap::iterator it = downloads_.find(id);
@@ skipping 38 matching lines @@
     ui_loop_->PostTask(FROM_HERE, NewRunnableMethod(
         this, &DownloadFileManager::StopUpdateTimer));
 }
 
 // static
 void DownloadFileManager::DeleteFile(const FilePath& path) {
   // Make sure we only delete files.
   if (!file_util::DirectoryExists(path))
     file_util::Delete(path, false);
 }