Issue 115717: Roll webkit DEPS and fix compile errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115717: Roll webkit DEPS and fix compile errors. (Closed)

Created:
11 years, 7 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Roll webkit DEPS and fix compile errors. TBR=wtc BUG=None TEST=It compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16784

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -17 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/resource_handle_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webframeloaderclient_impl.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	webkit/glue/weburlrequest.h	View	1 chunk	+4 lines, -4 lines	1 comment	Download
M	webkit/glue/weburlrequest_impl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/weburlrequest_impl.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/115717/diff/15/1006 File webkit/glue/weburlrequest.h (right): http://codereview.chromium.org/115717/diff/15/1006#newcode40 Line 40: // Get/set the URL of the first ...

11 years, 7 months ago (2009-05-22 20:46:03 UTC) #2

abarth-chromium

11 years, 7 months ago (2009-05-22 21:06:17 UTC) #3

On 2009/05/22 20:46:03, wtc wrote:
> What does the first party for cookies mean?

When you need to figure out if a cookie is a third-party cookie (for blocking
third-party cookies), you need to know who the "first-party" is.

Most of the time its the main document URL, but not always.  The old name was
confusing people into assuming it was the main document URL all the time, which
lead to subtle bugs.

Expand Messages | Collapse Messages

Issue 115717: Roll webkit DEPS and fix compile errors. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages