Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: src/objects-inl.h

Issue 115706: X64: Omitted creating native builtins and using them in test-heap. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index a13e13febcec68846085c6a5d7eab962ad09ab4d..c3c95be39dd2d7c06e5b0af4aa6e068119263067 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -764,9 +764,11 @@ Failure* Failure::RetryAfterGC(int requested_bytes) {
Failure* Failure::Construct(Type type, int value) {
int info = (value << kFailureTypeTagSize) | type;
+ // TODO(X64): Stop using Smi validation for non-smi checks, even if they
+ // happen to be identical at the moment.
ASSERT(Smi::IsValid(info)); // Same validation check as in Smi
return reinterpret_cast<Failure*>(
- static_cast<intptr_t>((info << kFailureTagSize) | kFailureTag));
+ (static_cast<intptr_t>(info) << kFailureTagSize) | kFailureTag);
}

Powered by Google App Engine
This is Rietveld 408576698