Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: src/heap.h

Issue 115706: X64: Omitted creating native builtins and using them in test-heap. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1040 // always set for pointers into new space. 1040 // always set for pointers into new space.
1041 class VerifyPointersAndRSetVisitor: public ObjectVisitor { 1041 class VerifyPointersAndRSetVisitor: public ObjectVisitor {
1042 public: 1042 public:
1043 void VisitPointers(Object** start, Object** end) { 1043 void VisitPointers(Object** start, Object** end) {
1044 for (Object** current = start; current < end; current++) { 1044 for (Object** current = start; current < end; current++) {
1045 if ((*current)->IsHeapObject()) { 1045 if ((*current)->IsHeapObject()) {
1046 HeapObject* object = HeapObject::cast(*current); 1046 HeapObject* object = HeapObject::cast(*current);
1047 ASSERT(Heap::Contains(object)); 1047 ASSERT(Heap::Contains(object));
1048 ASSERT(object->map()->IsMap()); 1048 ASSERT(object->map()->IsMap());
1049 if (Heap::InNewSpace(object)) { 1049 if (Heap::InNewSpace(object)) {
1050 #ifndef V8_HOST_ARCH_64_BIT
1051 // TODO(X64): Reenable when RSet works.
1050 ASSERT(Page::IsRSetSet(reinterpret_cast<Address>(current), 0)); 1052 ASSERT(Page::IsRSetSet(reinterpret_cast<Address>(current), 0));
Kevin Millikin (Chromium) 2009/05/22 12:47:49 Same comment---Page::IsRSetSet could return true i
Lasse Reichstein 2009/05/22 13:10:10 Done. Returning true should be a safe approximatio
1053 #endif // V8_HOST_ARCH_64_BIT
1051 } 1054 }
1052 } 1055 }
1053 } 1056 }
1054 } 1057 }
1055 }; 1058 };
1056 #endif 1059 #endif
1057 1060
1058 1061
1059 // Space iterator for iterating over all spaces of the heap. 1062 // Space iterator for iterating over all spaces of the heap.
1060 // Returns each space in turn, and null when it is done. 1063 // Returns each space in turn, and null when it is done.
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
1306 int marked_count_; 1309 int marked_count_;
1307 1310
1308 // The count from the end of the previous full GC. Will be zero if there 1311 // The count from the end of the previous full GC. Will be zero if there
1309 // was no previous full GC. 1312 // was no previous full GC.
1310 int previous_marked_count_; 1313 int previous_marked_count_;
1311 }; 1314 };
1312 1315
1313 } } // namespace v8::internal 1316 } } // namespace v8::internal
1314 1317
1315 #endif // V8_HEAP_H_ 1318 #endif // V8_HEAP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698