Remove list copy constructor (for which there was no corresponding...

src/list-inl.h

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 16 matching lines @@
 
 #ifndef V8_LIST_INL_H_
 #define V8_LIST_INL_H_
 
 #include "list.h"
 
 namespace v8 { namespace internal {
 
 
 template<typename T, class P>
-List<T, P>::List(const List<T, P>& other) {
-  ASSERT(other.capacity() >= 0);
-  capacity_ = other.capacity();
-  length_ = other.length();
-  if (capacity_ > 0) {
-    data_ = NewData(capacity_);
-    int copy_size = length_ * sizeof(T);
-    const int kMinMemCpySize = 64;
-    if (copy_size < kMinMemCpySize) {
-      for (int i = 0; i < length_; i++) data_[i] = other.data_[i];
-    } else {
-      memcpy(data_, other.data_, copy_size);
-    }
-  } else {
-    data_ = NULL;
-  }
-}
-
-
-template<typename T, class P>
 void List<T, P>::Add(const T& element) {
   if (length_ < capacity_) {
     data_[length_++] = element;
   } else {
     List<T, P>::ResizeAdd(element);
   }
 }
 
 
+template<typename T, class P>
+void List<T, P>::AddAll(const List<T, P>& other) {
+  int result_length = length_ + other.length_;
+  if (capacity_ < result_length) Resize(result_length);
+  for (int i = 0; i < other.length_; i++) {
+    data_[length_ + i] = other.data_[i];
+  }
+  length_ = result_length;
+}
+
+
 // Use two layers of inlining so that the non-inlined function can
 // use the same implementation as the inlined version.
 template<typename T, class P>
 void List<T, P>::ResizeAdd(const T& element) {
   ResizeAddInternal(element);
 }
 
 
 template<typename T, class P>
 void List<T, P>::ResizeAddInternal(const T& element) {
   ASSERT(length_ >= capacity_);
   // Grow the list capacity by 50%, but make sure to let it grow
   // even when the capacity is zero (possible initial case).
   int new_capacity = 1 + capacity_ + (capacity_ >> 1);
+  // Since the element reference could be an element of the list, copy
+  // it out of the old backing storage before resizing.
+  T temp = element;
+  Resize(new_capacity);
+  data_[length_++] = temp;
+}
+
+
+template<typename T, class P>
+void List<T, P>::Resize(int new_capacity) {
   T* new_data = List<T, P>::NewData(new_capacity);
   memcpy(new_data, data_, capacity_ * sizeof(T));
-  // Since the element reference could be an element of the list,
-  // assign it to the new backing store before deleting the old.
-  new_data[length_++] = element;
   List<T, P>::DeleteData(data_);
   data_ = new_data;
   capacity_ = new_capacity;
 }
 
 
 template<typename T, class P>
 Vector<T> List<T, P>::AddBlock(T value, int count) {
   int start = length_;
   for (int i = 0; i < count; i++) Add(value);
@@ skipping 63 matching lines @@
   ASSERT(capacity >= 0);
   data_ = (capacity > 0) ? NewData(capacity) : NULL;
   capacity_ = capacity;
   length_ = 0;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_LIST_INL_H_