Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 115702: Fix future build break from upstream renaming patch.... (Closed)

Created:
11 years, 7 months ago by abarth-chromium
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix future build break from upstream renaming patch. R=wtc BUG=None TEST=It compiles! It must work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16748

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_handle_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
11 years, 7 months ago (2009-05-22 08:39:43 UTC) #1
wtc
LGTM. I don't understand how you can rename our method invocations before renaming the method ...
11 years, 7 months ago (2009-05-22 15:45:07 UTC) #2
abarth-chromium
On 2009/05/22 15:45:07, wtc wrote: > I don't understand how you can rename our method ...
11 years, 7 months ago (2009-05-22 16:51:27 UTC) #3
wtc
I see. You may want to edit the Description of the CL because the current ...
11 years, 7 months ago (2009-05-22 16:56:04 UTC) #4
abarth-chromium
On 2009/05/22 16:56:04, wtc wrote: > I see. You may want to edit the Description ...
11 years, 7 months ago (2009-05-22 17:02:14 UTC) #5
wtc
11 years, 7 months ago (2009-05-22 17:04:40 UTC) #6
OK! :-)

Powered by Google App Engine
This is Rietveld 408576698