Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Issue 115681: switch to using native JSON object (Closed)

Created:
11 years, 7 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman, pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : pre CR changes #

Total comments: 2

Patch Set 3 : gyp removal #

Patch Set 4 : all in one #

Patch Set 5 : all in one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -361 lines) Patch
M chrome/renderer/extensions/event_bindings.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/extensions/extension_api_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/js_only_v8_extensions.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/js_only_v8_extensions.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/renderer/render_thread.cc View 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/event_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/renderer/resources/renderer_extension_bindings.js View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/devtools/js/devtools.html View 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/devtools/js/json.js View 1 chunk +0 lines, -328 lines 0 comments Download
M webkit/glue/webkit_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/webkit.gyp View 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
11 years, 7 months ago (2009-05-26 23:09:26 UTC) #1
rafaelw
adding Pavel as a reviewer. Pavel, just review that is it safe to remove json.js ...
11 years, 7 months ago (2009-05-26 23:20:31 UTC) #2
Aaron Boodman
lgtm hooray for deleting code. http://codereview.chromium.org/115681/diff/12/20 File chrome/renderer/resources/event_bindings.js (left): http://codereview.chromium.org/115681/diff/12/20#oldcode38 Line 38: args = goog.json.parse(args); ...
11 years, 7 months ago (2009-05-27 01:28:29 UTC) #3
rafaelw
http://codereview.chromium.org/115681/diff/12/20 File chrome/renderer/resources/event_bindings.js (left): http://codereview.chromium.org/115681/diff/12/20#oldcode38 Line 38: args = goog.json.parse(args); On 2009/05/27 01:28:29, Aaron Boodman ...
11 years, 7 months ago (2009-05-27 01:41:16 UTC) #4
pfeldman
11 years, 7 months ago (2009-05-27 04:38:21 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698