Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: PRESUBMIT.py

Issue 115679: Fix the PRESUBMIT.py for depot_tools. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 66692d2d3f8c75164b2350db702acc4f81efca2e..0d7e08a0bd465b48460b03fd4c41cbe535b39590 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -9,23 +9,27 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
details on the presubmit API built into gcl.
"""
+UNIT_TESTS = [
+ 'tests.gcl_unittest',
+ 'tests.gclient_test',
+ 'tests.presubmit_unittest',
+ 'tests.revert_unittest',
+ 'tests.trychange_unittest',
+]
def CheckChangeOnUpload(input_api, output_api):
- return RunUnitTests(input_api, output_api)
+ output = []
+ output.extend(input_api.canned_checks.RunPythonUnitTests(input_api,
+ output_api,
+ UNIT_TESTS))
+ return output
def CheckChangeOnCommit(input_api, output_api):
- unit_tests = [
- 'tests.gcl_unittest',
- 'tests.gclient_test',
- 'tests.presubmit_unittest',
- 'tests.revert_unittest',
- 'tests.trychange_unittest',
- ]
output = []
output.extend(input_api.canned_checks.RunPythonUnitTests(input_api,
output_api,
- unit_tests))
+ UNIT_TESTS))
output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api,
output_api))
return output
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698