Issue 115679: Fix the PRESUBMIT.py for depot_tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115679: Fix the PRESUBMIT.py for depot_tools. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix the PRESUBMIT.py for depot_tools. Ironically, it was broken. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16856

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+13 lines, -9 lines	0 comments	Download

Total messages: 7 (0 generated)

jam

i'm not familiar at all with that file, so it's hard for me to review. ...

11 years, 7 months ago (2009-05-22 20:12:05 UTC) #3

M-A Ruel

On 2009/05/22 20:12:05, John Abd-El-Malek wrote: > i'm not familiar at all with that file, ...

11 years, 7 months ago (2009-05-22 20:13:29 UTC) #4

Jói Sigurðsson

11 years, 7 months ago (2009-05-25 15:11:22 UTC) #7

LGTM

Sorry for the delay, didn't see this until you added my address to the To or CC
line.