Middle clicking on a bookmark from the bookmark manager now...

Middle clicking on a bookmark from the bookmark manager now
opens that bookmark in a new foreground tab.

BUG=7788

[brettw, 2009-05-21 22:34:35]

I'm adding Scott since he wrote the table stuff. My question is especially
whether the select behavior for middle click should be in the table view or the
bookmarks manager.

[sky, 2009-05-21 22:41:18]

LGTM with the following changes.

http://codereview.chromium.org/115665/diff/14/1004
File views/controls/table/table_view.cc (right):

http://codereview.chromium.org/115665/diff/14/1004#newcode660
Line 660: table_view->SetSelectedState(model_index, true);
Use Select here rather than clearing than selecting. It does both for you.

http://codereview.chromium.org/115665/diff/14/1004#newcode1497
Line 1497: if (!ignore_listview_change_ && table_view_observer_) {
nit: no {} here.

[brettw, 2009-05-21 22:50:15]

http://codereview.chromium.org/115665/diff/14/1003
File AUTHORS (right):

http://codereview.chromium.org/115665/diff/14/1003#newcode40
Line 40: Meelap Shah <meelapshah@gmail.com>
I don't think you need to put your name in here, since you're working for
Google, which is already listed. This is only for external contributors not
covered by our contract.

http://codereview.chromium.org/115665/diff/14/1006
File chrome/browser/views/bookmark_manager_view.cc (right):

http://codereview.chromium.org/115665/diff/14/1006#newcode355
Line 355: // Middle click on a folder does nothing
Comments should be complete sentences and end with a period.

[meelapshah, 2009-05-21 23:03:52]

Changes made.

On 2009/05/21 22:50:15, brettw wrote:
> http://codereview.chromium.org/115665/diff/14/1003
> File AUTHORS (right):
> 
> http://codereview.chromium.org/115665/diff/14/1003#newcode40
> Line 40: Meelap Shah <meelapshah@gmail.com>
> I don't think you need to put your name in here, since you're working for
> Google, which is already listed. This is only for external contributors not
> covered by our contract.
> 
> http://codereview.chromium.org/115665/diff/14/1006
> File chrome/browser/views/bookmark_manager_view.cc (right):
> 
> http://codereview.chromium.org/115665/diff/14/1006#newcode355
> Line 355: // Middle click on a folder does nothing
> Comments should be complete sentences and end with a period.

[brettw, 2009-05-22 17:54:26]

LGTM, I'll check this in later today.