Issue 115664: Explicitly enable /INCREMENTAL linking for gyp-generated Debug builds,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115664: Explicitly enable /INCREMENTAL linking for gyp-generated Debug builds,... (Closed)

Created:
11 years, 7 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
bradn

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Mark Mentovai

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Explicitly enable /INCREMENTAL linking for gyp-generated Debug builds. Explicitly disable it (/INCREMENTAL:NO) for Release, and for the following targets that require it: chrome.dll interactive_ui_tests.exe perf_tests.exe unit_tests.exe Explicitly specificy /SUBSYSTEM:CONSOLE as default for linking, and match current practice by overriding with /SUBSYSTEM:WINDOWS for: chrome.exe chrome.dll media_player.exe sandbox_poc.exe TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16698

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -1 line)			Patch
M	build/common.gypi	View	1	4 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1	5 chunks	+36 lines, -0 lines	0 comments	Download
M	media/media.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	sandbox/sandbox.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 7 months ago (2009-05-21 23:55:40 UTC) #3

Updating with overrides for targets that explicitly need /INCREMENTAL:NO and
/SUBSYSTEM:WINDOWS.  Should match current practice.

mmentovai, would appreciate your eyes on the conditions in case you spot
opportunities for more effective/readable patterns.

Expand Messages | Collapse Messages