src/dtoa-config.c - Issue 11564: Added support for building V8 on Windows with either the shared or static ver...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/dtoa-config.c

Issue 11564: Added support for building V8 on Windows with either the shared or static ver... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/dtoa-config.c

===================================================================

--- src/dtoa-config.c (revision 812)

+++ src/dtoa-config.c (working copy)

@@ -58,7 +58,18 @@

* If it's included after strtod is redefined as gay_strtod, it will mangle

* the name of gay_strtod, which is unwanted. */

#include <stdlib.h>

#endif

+/* stdlib.h on Windows adds __declspec(dllimport) to all functions when using

+ * the DLL version of the CRT (compiling with /MD or /MDd). If stdlib.h is

+ * included after strtod is redefined as gay_strtod, it will add

+ * __declspec(dllimport) to gay_strtod, which causes the compilation of

+ * gay_strtod in dtoa.c to fail.

+*/

+#if defined(WIN32) && defined(_DLL)

+#include "stdlib.h"

+#endif

/* Make sure we use the David M. Gay version of strtod(). On Linux, we

* cannot use the same name (maybe the function does not have weak

* linkage?). */

« no previous file with comments | « SConstruct ('k') | no next file » | no next file with comments »