Fixing the detection of aliased eval so that it is exact....

src/ast.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 846 matching lines @@
   Expression* key_;
   int pos_;
 
   // Dummy property used during preparsing
   static Property this_property_;
 };
 
 
 class Call: public Expression {
  public:
+  enum EvalType {
+    ALIASED,               // Either not eval or an aliased eval.
+    POTENTIALLY_DIRECT     // Looks like a direct eval at codegen time.
+                           // Needs to be determined at runtime whether the
+                           // eval is direct.
+  };
+
   Call(Expression* expression,
        ZoneList<Expression*>* arguments,
-       bool is_eval,
+       EvalType eval_type,
        int pos)
       : expression_(expression),
         arguments_(arguments),
-        is_eval_(is_eval),
+        eval_type_(eval_type),
         pos_(pos) { }
 
   virtual void Accept(Visitor* v);
 
   // Type testing and conversion.
   virtual Call* AsCall() { return this; }
 
   Expression* expression() const { return expression_; }
   ZoneList<Expression*>* arguments() const { return arguments_; }
-  bool is_eval()  { return is_eval_; }
+  EvalType eval_type()  { return eval_type_; }
   int position() { return pos_; }
 
   static Call* sentinel() { return &sentinel_; }
 
  private:
   Expression* expression_;
   ZoneList<Expression*>* arguments_;
-  bool is_eval_;
+  EvalType eval_type_;
   int pos_;
 
   static Call sentinel_;
 };
 
 
 class CallNew: public Call {
  public:
   CallNew(Expression* expression, ZoneList<Expression*>* arguments, int pos)
-      : Call(expression, arguments, false, pos) { }
+      : Call(expression, arguments, ALIASED, pos) { }
 
   virtual void Accept(Visitor* v);
 };
 
 
 // The CallRuntime class does not represent any official JavaScript
 // language construct. Instead it is used to call a C or JS function
 // with a set of arguments. This is used from the builtins that are
 // implemented in JavaScript (see "v8natives.js").
 class CallRuntime: public Expression {
@@ skipping 317 matching lines @@
 #undef DEF_VISIT
 
  private:
   bool stack_overflow_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_AST_H_