Issue 115592: - Record cache hit rates at different levels in the compilation cache...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115592: - Record cache hit rates at different levels in the compilation cache... (Closed)

Created:
11 years, 7 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
DaveMoore, Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Record cache hit rates at different levels in the compilation cache for scripts. Committed: http://code.google.com/p/v8/source/detail?r=2052

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/compilation-cache.cc	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
	M	src/counters.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/115592/diff/1/3 File src/compilation-cache.cc (right): http://codereview.chromium.org/115592/diff/1/3#newcode167 Line 167: static void* script_histogram_ = StatsTable::CreateHistogram( What's up ...

11 years, 7 months ago (2009-05-22 06:25:22 UTC) #2

iposva

11 years, 7 months ago (2009-05-22 06:40:12 UTC) #3

http://codereview.chromium.org/115592/diff/1/3
File src/compilation-cache.cc (right):

http://codereview.chromium.org/115592/diff/1/3#newcode167
Line 167: static void* script_histogram_ = StatsTable::CreateHistogram(
On 2009/05/22 06:25:22, Kasper Lund wrote:
> What's up with the trailing _?

Used to be a static member of the class. Fixed.

Expand Messages | Collapse Messages

Issue 115592: - Record cache hit rates at different levels in the compilation cache... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages