Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: PRESUBMIT.py

Issue 115577: Revert "Revert "Add presubmit checks to look for BUG= and TEST= tags in change list description."" (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d73d5667267881c7e0fa10accba10362f4f32d2e..c2f0b77947aa9db7db09c581bd5fa138954c32f3 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -40,14 +40,18 @@ def ReadFile(path):
def CheckChangeOnUpload(input_api, output_api):
# TODO(maruel): max_cols is temporarily disabled. Reenable once the source
# tree is in better shape.
- return LocalChecks(input_api, output_api, max_cols=0)
+ return (LocalChecks(input_api, output_api, max_cols=0) +
+ input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) +
+ input_api.canned_checks.CheckChangeHasTestField(input_api, output_api))
def CheckChangeOnCommit(input_api, output_api):
# TODO(maruel): max_cols is temporarily disabled. Reenable once the source
# tree is in better shape.
return (LocalChecks(input_api, output_api, max_cols=0) +
- input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
+ input_api.canned_checks.CheckDoNotSubmit(input_api, output_api) +
+ input_api.canned_checks.CheckChangeHasBugField(input_api, output_api) +
+ input_api.canned_checks.CheckChangeHasTestField(input_api, output_api))
def LocalChecks(input_api, output_api, max_cols=80):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698