Issue 115573: Mac: Modify Omnibox to notice when the window loses key, too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115573: Mac: Modify Omnibox to notice when the window loses key, too. (Closed)

Created:
11 years, 7 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Modify Omnibox to notice when the window loses key, too. http://crbug.com/12252 TEST=Type "word" in omnibox. Click on some other window. Popup should dissappear.

Patch Set 3 : Unregister notifications before releasing edit_helper_. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1 2	5 chunks	+31 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

http://codereview.chromium.org/115573/diff/1001/1003 File chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (right): http://codereview.chromium.org/115573/diff/1001/1003#newcode130 Line 130: NSNotificationCenter* nc = [NSNotificationCenter defaultCenter]; you need to ...

11 years, 7 months ago (2009-05-20 17:05:04 UTC) #2

Scott Hess - ex-Googler

11 years, 7 months ago (2009-05-20 17:13:41 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 115573: Mac: Modify Omnibox to notice when the window loses key, too. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Wordsmithing. #

Patch Set 3 : Unregister notifications before releasing edit_helper_. #

Messages