Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 115559: X64: Disabled RSet in 64-bit mode. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64: Disabled RSet in 64-bit mode. Made a few more places use intptr_t instead of int for pointer arithmetic. Ensure that objects have a declared size that matches heap object alignment.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -27 lines) Patch
M src/heap.cc View 3 chunks +30 lines, -8 lines 0 comments Download
M src/heap-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 6 chunks +16 lines, -12 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/spaces-inl.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8threads.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
Review of changes including GC.
11 years, 7 months ago (2009-05-20 07:08:06 UTC) #1
Kevin Millikin (Chromium)
LGTM.
11 years, 7 months ago (2009-05-20 07:49:07 UTC) #2
William Hesse
11 years, 7 months ago (2009-05-20 08:42:55 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698