Issue 115558: Fix: Text change in omnibox is lost if the tab is dragged to other tabstrip....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115558: Fix: Text change in omnibox is lost if the tab is dragged to other tabstrip.... (Closed)

Created:
11 years, 7 months ago by yuzo

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fix: Text change in omnibox is lost if the tab is dragged to other tabstrip. Currently the text is not saved when a tab is detached from a tabstrip. As a result the change made to the text is lost. Tested manually. BUG=10632

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yuzo

Ping? In case you are too busy, can you find a reviewer for this?

11 years, 7 months ago (2009-05-25 06:36:18 UTC) #2

Landed in r17012.

Expand Messages | Collapse Messages