Issue 115553: Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115553: Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was ... (Closed)

Created:
11 years, 7 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove TRACK_HWND_CREATION/TRACK_HWND_DESTRUCTION macro since the bug it was created for has long been closed. This code causes crashes when the browser is closed with the task manager open (in debug builds at the very least). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16462

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -114 lines)			Patch
M	base/win_util.h	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	base/win_util.cc	View	2 chunks	+0 lines, -63 lines	0 comments	Download
M	chrome/browser/plugin_process_host.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	views/controls/native_control.cc	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	views/controls/native_control_win.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	views/controls/text_field.cc	View	4 chunks	+0 lines, -14 lines	0 comments	Download
M	views/widget/widget_win.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl.cc	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	webkit/tools/test_shell/webwidget_host_win.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages