Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gcl.py

Issue 115534: When -s or --server is used, don't try the patch. (Closed)
Patch Set: Patch fixed Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index bbcba87ec9d3dd8b7a3c429fa609007752fd168a..d8c09afa91d4f272b217dcf84ed9730a8e63f9ac 100755
--- a/gcl.py
+++ b/gcl.py
@@ -715,8 +715,13 @@ def UploadCL(change_info, args):
args.remove("--clobber")
clobber = True
- # TODO(pamg): Do something when tests are missing. The plan is to upload a
- # message to Rietveld and have it shown in the UI attached to this patch.
+ # Disable try when the server is overridden.
+ server_1 = re.compile(r"^-s\b.*")
+ server_2 = re.compile(r"^--server\b.*")
+ for arg in args:
+ if server_1.match(arg) or server_2.match(arg):
+ no_try = True
+ break
upload_arg = ["upload.py", "-y"]
upload_arg.append("--server=" + GetCodeReviewSetting("CODE_REVIEW_SERVER"))
« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698