Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: PRESUBMIT.py

Issue 115516: Add new presubmit check RunPythonUnitTests. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 4694a28617842e226c91e0ded1f2bc47ae7e58ea..66692d2d3f8c75164b2350db702acc4f81efca2e 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -15,24 +15,17 @@ def CheckChangeOnUpload(input_api, output_api):
def CheckChangeOnCommit(input_api, output_api):
- return (RunUnitTests(input_api, output_api) +
- input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
-
-
-def RunUnitTests(input_api, output_api):
- import unittest
- tests_suite = []
- test_loader = unittest.TestLoader()
- def LoadTests(module_name):
- module = __import__(module_name)
- for part in module_name.split('.')[1:]:
- module = getattr(module, part)
- tests_suite.extend(test_loader.loadTestsFromModule(module)._tests)
- # List all the test modules to test here:
- LoadTests('tests.gcl_unittest')
- LoadTests('tests.gclient_test')
- LoadTests('tests.presubmit_unittest')
- LoadTests('tests.trychange_unittest')
- unittest.TextTestRunner(verbosity=0).run(unittest.TestSuite(tests_suite))
- # TODO(maruel): Find a way to block the check-in.
- return []
+ unit_tests = [
+ 'tests.gcl_unittest',
+ 'tests.gclient_test',
+ 'tests.presubmit_unittest',
+ 'tests.revert_unittest',
+ 'tests.trychange_unittest',
+ ]
+ output = []
+ output.extend(input_api.canned_checks.RunPythonUnitTests(input_api,
+ output_api,
+ unit_tests))
+ output.extend(input_api.canned_checks.CheckDoNotSubmit(input_api,
+ output_api))
+ return output
« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698