Issue 115509: Add ARMv7 defines to preprocessor checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115509: Add ARMv7 defines to preprocessor checks (Closed)

Created:
11 years, 7 months ago by Joel Stanley (old)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev, Dean McNamee, joel_jms.id.au

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add ARMv7 defines to preprocessor checks The preprocessor defines check for v5t and v5te. This patch adds v7 and v7-a which provide support for -march=armv7 and -mcpu=cortex-a8 respectively. This is to support my work compiling chromium on arm, see http://crbug.com/12028

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/arm/macro-assembler-arm.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM. Assuming you are Joel Stanley <joel@jms.id.au> I will go ahead and commit this for ...

11 years, 7 months ago (2009-05-19 12:37:53 UTC) #2

Joel Stanley (old)

11 years, 7 months ago (2009-05-19 12:57:51 UTC) #3

On 2009/05/19 12:37:53, Erik Corry wrote:
> LGTM.   Assuming you are Joel Stanley <joel@jms.id.au> I will go ahead and
> commit this for you.  Thanks.

Yes, that's me.

Thanks

Expand Messages | Collapse Messages