Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 115505: Dismiss the bookmark manager when Ctrl-W is pressed (Closed)

Created:
11 years, 7 months ago by tyoshino-do-not-use
Modified:
9 years, 7 months ago
Reviewers:
sky, Venkat Yellapu
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Dismiss the bookmark manager when Ctrl-W is pressed. The bookmark manager is a window not a dialog. It should be dismissed by Ctrl-W not by Esc as well as browser tabs in the main window. TEST=Open the bookmark manager, then press Ctrl-W. It should be closed. BUG=4030

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/views/bookmark_manager_view.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tyoshino-do-not-use
Hi Venkat, (and CC-ing sky@ and ben@) I'd like you to do code review. I ...
11 years, 7 months ago (2009-05-19 08:35:22 UTC) #1
sky
On 2009/05/19 08:35:22, tyoshino wrote: > Hi Venkat, (and CC-ing sky@ and ben@) > > ...
11 years, 7 months ago (2009-05-22 23:41:16 UTC) #2
tyoshino-do-not-use
Thank you for the update. As discussed on bug 4030, I've updated this CL. Hi ...
11 years, 7 months ago (2009-05-27 03:33:52 UTC) #3
sky
LGTM
11 years, 7 months ago (2009-05-27 03:51:33 UTC) #4
tyoshino-do-not-use
Thank you for review. Could you please check this in on behalf of me? I ...
11 years, 7 months ago (2009-05-27 03:56:52 UTC) #5
sky
Certainly. Committed in r16982. -Scott
11 years, 7 months ago (2009-05-27 14:35:04 UTC) #6
sky
*SIGH* This was backed out in 16985 because the mac build broke. It wasn't this ...
11 years, 7 months ago (2009-05-27 16:37:59 UTC) #7
tyoshino-do-not-use
11 years, 7 months ago (2009-05-28 04:16:25 UTC) #8
On 2009/05/27 16:37:59, sky wrote:
> *SIGH*
> This was backed out in 16985 because the mac build broke. It wasn't this cl's
> fault though, so I landed it again in 16987. Lets hope it sticks.
> 
>   -Scott

Looks successful. Thanks.

Powered by Google App Engine
This is Rietveld 408576698