Include initial definitions in reaching definitions analysis.

Include initial definitions in reaching definitions analysis.

Include the initial definitions for parameters on input to the
function, and the initial definition of stack-allocated locals as
undefined.

Committed: http://code.google.com/p/v8/source/detail?r=4206

[fschneider, 2010-03-22 13:49:29]

LGTM.

http://codereview.chromium.org/1155006/diff/1/3
File src/data-flow.cc (right):

http://codereview.chromium.org/1155006/diff/1/3#newcode1876
src/data-flow.cc:1876: // Step 1: For each (stack-allocated) variable, identify
the set of all
We don't handle any other variables? Maybe change comment:

(stack-allocated) -> stack-allocated

http://codereview.chromium.org/1155006/diff/1/3#newcode1889
src/data-flow.cc:1889: variables[IndexFor(var, variable_count_)]->Add(i +
variable_count_);
variables->at(IndexFor(var, variable_count_))

for consistency with the rest?

[Kevin Millikin (Chromium), 2010-03-22 14:06:40]

http://codereview.chromium.org/1155006/diff/1/3
File src/data-flow.cc (right):

http://codereview.chromium.org/1155006/diff/1/3#newcode1876
src/data-flow.cc:1876: // Step 1: For each (stack-allocated) variable, identify
the set of all
On 2010/03/22 13:49:29, fschneider wrote:
> We don't handle any other variables? Maybe change comment:
> 
> (stack-allocated) -> stack-allocated
> 
> 

Done.

http://codereview.chromium.org/1155006/diff/1/3#newcode1889
src/data-flow.cc:1889: variables[IndexFor(var, variable_count_)]->Add(i +
variable_count_);
On 2010/03/22 13:49:29, fschneider wrote:
> variables->at(IndexFor(var, variable_count_))
> 
> for consistency with the rest?

It would be variables.at(...).  I'll leave it with [] for now.