Issue 1155005: views: [accessibility] Add accessible name for the Close button in generic Wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155005: views: [accessibility] Add accessible name for the Close button in generic Wi... (Closed)

Created:
10 years, 9 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Chris Guillory

CC:
chromium-reviews, ben+cc_chromium.org, Jonas Klink (Google), dmazzoni

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

views: [accessibility] Add accessible name for the Close button in generic Window. BUG=9614 TEST=open AccExplorer, open a dialog window, point it to the Close button in the top-right corner, see if it shows Close as the accessible name. Patch from Thiago Farina <thiago.farina@gmail.com>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42270

Patch Set 1 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	app/resources/app_strings.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	views/window/custom_frame_view.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina (gmail-do not use)

Hi Chris, could you review this to me? Note: I didn't do this for the ...

10 years, 9 months ago (2010-03-21 01:56:46 UTC) #1

Chris Guillory

10 years, 9 months ago (2010-03-22 22:29:07 UTC) #2

LGTM. Let's get the change in for the rest of the buttons as well. I've updated
the bug to reflect that.

Expand Messages | Collapse Messages