Issue 115489: Implement the sad tab crash animation for tabs in linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115489: Implement the sad tab crash animation for tabs in linux. (Closed)

Created:
11 years, 7 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, willchan no longer on Chromium

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement the sad tab crash animation for tabs in linux. BUG=11615 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16342

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -3 lines)			Patch
	M	chrome/browser/gtk/tabs/tab_renderer_gtk.h	View		3 chunks	+18 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View		6 chunks	+108 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

I just tried this and it didn't seem to work (no animation at all, no ...

11 years, 7 months ago (2009-05-19 08:56:45 UTC) #3

Dean McNamee

On 2009/05/19 08:56:45, Dean McNamee wrote: > I just tried this and it didn't seem ...

11 years, 7 months ago (2009-05-19 08:57:58 UTC) #4

James Hawkins

11 years, 7 months ago (2009-05-19 16:57:39 UTC) #5

On 2009/05/19 08:57:58, Dean McNamee wrote:
> On 2009/05/19 08:56:45, Dean McNamee wrote:
> > I just tried this and it didn't seem to work (no animation at all, no
> favicon). 
> > Any ideas?
> 
> (btw, my reproduction is going to about:crash from the new tab page, but it
> seems all favicons are broken this way?)

What WM are you using?  I tried it with compiz and metacity (w&w/out
compositing) and it worked fine.

Expand Messages | Collapse Messages