Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: webkit/tools/test_shell/test_webview_delegate.cc

Issue 115486: Take 2 at fixing relativeanchor-{basic,frames}.html.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/layout_tests/test_expectations.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_webview_delegate.cc
===================================================================
--- webkit/tools/test_shell/test_webview_delegate.cc (revision 16304)
+++ webkit/tools/test_shell/test_webview_delegate.cc (working copy)
@@ -794,17 +794,6 @@
if (frame == top_loading_frame_) {
top_loading_frame_ = NULL;
- // It is important to update the content state for the current navigation
- // entry in case we are done with the test and need to dump the back/
- // forward list.
- std::string state;
- if (shell_->webView()->GetMainFrame()->GetCurrentHistoryState(&state)) {
- TestNavigationEntry* entry =
- shell_->navigation_controller()->GetLastCommittedEntry();
- if (entry)
- entry->SetContentState(state);
- }
-
if (shell_->layout_test_mode())
shell_->layout_test_controller()->LocationChangeDone();
}
@@ -864,6 +853,10 @@
entry->SetURL(GURL(request.GetURL()));
}
+ std::string state;
+ if (frame->GetCurrentHistoryState(&state))
+ entry->SetContentState(state);
+
shell_->navigation_controller()->DidNavigateToEntry(entry.release());
last_page_id_updated_ = std::max(last_page_id_updated_, page_id_);
« no previous file with comments | « webkit/tools/layout_tests/test_expectations.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698