Issue 115482: Move WebMediaPlayerClientImpl files to WebKit API src location....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115482: Move WebMediaPlayerClientImpl files to WebKit API src location.... (Closed)

Created:
11 years, 7 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move WebMediaPlayerClientImpl files to WebKit API src location. This involves adding a temporary glue function, which will be removed once WebFrame / WebView are part of the WebKit API. R=hclam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16336

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+476 lines, -790 lines)			Patch
M	chrome/renderer/render_process.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_process.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/renderer_glue.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	webkit/api/public/WebKit.h	View	3 chunks	+6 lines, -3 lines	0 comments	Download
A +	webkit/api/src/MediaPlayerPrivateChromium.cpp	View	1 chunk	+35 lines, -14 lines	0 comments	Download
A	webkit/api/src/TemporaryGlue.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	webkit/api/src/WebKit.cpp	View	4 chunks	+11 lines, -3 lines	0 comments	Download
A +	webkit/api/src/WebMediaPlayerClientImpl.h	View	1 chunk	+90 lines, -84 lines	0 comments	Download
A +	webkit/api/src/WebMediaPlayerClientImpl.cpp	View	2 chunks	+241 lines, -203 lines	0 comments	Download
D	webkit/glue/media_player_private_impl.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
A	webkit/glue/temporary_glue.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	webkit/glue/webmediaplayerclient_impl.h	View	1 chunk	+0 lines, -101 lines	0 comments	Download
D	webkit/glue/webmediaplayerclient_impl.cc	View	1 chunk	+0 lines, -310 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	webkit/webkit.gyp	View	5 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alpha Left Google

11 years, 7 months ago (2009-05-18 22:24:28 UTC) #2

Good, so now RenderProcess loads the dll and RenderThread enables the media
player in WebKit, which isolates pretty well the loading of dlls from webkit,
good use of TemporaryGlue to get stuff in quickly. Thanks for doing this.

LGTM!

Expand Messages | Collapse Messages