Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 115464: Fix a failure to correctly set the static type on a frame element at a... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix a failure to correctly set the static type on a frame element at a backward jump. The frame entering the backward block is not used, so the this is mostly just a bookkeeping change. Committed: http://code.google.com/p/v8/source/detail?r=1989

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M src/arm/jump-target-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/frame-element.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/ia32/jump-target-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 3 chunks +16 lines, -11 lines 0 comments Download
M src/virtual-frame.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Chromium)
11 years, 7 months ago (2009-05-18 12:19:48 UTC) #1
William Hesse
http://codereview.chromium.org/115464/diff/1/4 File src/frame-element.h (right): http://codereview.chromium.org/115464/diff/1/4#newcode160 Line 160: !(static_type() == other.static_type())) { Why doesn't this use ...
11 years, 7 months ago (2009-05-18 12:50:46 UTC) #2
William Hesse
LGTM.
11 years, 7 months ago (2009-05-18 12:56:06 UTC) #3
Kevin Millikin (Chromium)
11 years, 7 months ago (2009-05-18 12:59:13 UTC) #4
http://codereview.chromium.org/115464/diff/1/3
File src/ia32/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/115464/diff/1/3#newcode409
Line 409: // Nothing except the register backing use_index has changed.
On 2009/05/18 12:50:46, William Hesse wrote:
> Sync bit may be changed without actually syncing.  Fixed in next revision of
> this patch already.

Good catch.  New change uploaded, check it out.

Powered by Google App Engine
This is Rietveld 408576698