Issue 115445: Set 'remote_fonts_enabled' to true in test_shell. Chrome has it off by defaul...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115445: Set 'remote_fonts_enabled' to true in test_shell. Chrome has it off by defaul... (Closed)

Created:
11 years, 7 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set 'remote_fonts_enabled' to true in test_shell. Chrome has it off by default, but we don't want to lose the test coverage for dynamic font support. So, we turn it on in test_shell. TBR=darin http://crbug.com/9633 TEST=The following two webkit tests pass: LayoutTests/fast/css/font-face-remote.html LayoutTests/fast/css/font-face-unicode-range.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16250

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webkit/tools/test_shell/test_shell.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

Just for the record, trybot results above are bogus. I don't know why they failed ...

11 years, 7 months ago (2009-05-17 00:42:27 UTC) #2

LGTM

Expand Messages | Collapse Messages