Issue 11544: Remove use of wide characters in stats table identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11544: Remove use of wide characters in stats table identifiers. (Closed)

Created:
12 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, Dean McNamee

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remove use of wide characters in stats table identifiers.

Patch Set 1 #

Created: 12 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -292 lines)
M	base/histogram.cc	View	2 chunks	+2 lines, -2 lines	0 comments
M	base/stats_counters.h	View	5 chunks	+8 lines, -8 lines	0 comments
M	base/stats_table.h	View	8 chunks	+10 lines, -10 lines	0 comments
M	base/stats_table.cc	View	22 chunks	+36 lines, -36 lines	0 comments
M	base/stats_table_unittest.cc	View	12 chunks	+64 lines, -64 lines	0 comments
M	net/url_request/url_request.cc	View	1 chunk	+1 line, -1 line	0 comments
M	webkit/glue/chromium_bridge_impl.cc	View	1 chunk	+8 lines, -3 lines	0 comments
M	webkit/glue/webframe_impl.cc	View	3 chunks	+4 lines, -3 lines	0 comments
M	webkit/port/bindings/scripts/CodeGeneratorV8.pm	View	6 chunks	+6 lines, -6 lines	0 comments
M	webkit/port/bindings/v8/V8MessagePortCustom.cpp	View	7 chunks	+7 lines, -7 lines	0 comments
M	webkit/port/bindings/v8/V8XMLHttpRequestCustom.cpp	View	34 chunks	+34 lines, -34 lines	0 comments
M	webkit/port/bindings/v8/npruntime.cpp	View	1 chunk	+1 line, -1 line	0 comments
M	webkit/port/bindings/v8/v8_custom.cpp	View	93 chunks	+110 lines, -110 lines	0 comments
M	webkit/port/platform/chromium/ChromiumBridge.h	View	1 chunk	+2 lines, -3 lines	0 comments
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+2 lines, -2 lines	0 comments
M	webkit/tools/test_shell/test_shell_main.cc	View	2 chunks	+2 lines, -2 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

A v8 change and a shared memory change can come in a follow-up.

12 years, 1 month ago (2008-11-20 21:54:23 UTC) #1

Dean McNamee

Wow, what a pain. Awesome, thanks. If it compiles, LG.

12 years, 1 month ago (2008-11-20 22:05:32 UTC) #2

Mike Belshe

lgtm; i'm assuming the v8 change has to go in at the same time? thanks ...

12 years, 1 month ago (2008-11-21 19:54:53 UTC) #3

Evan Martin

12 years, 1 month ago (2008-11-21 19:59:57 UTC) #4

On 2008/11/21 19:54:53, Mike Belshe wrote:
> lgtm; i'm assuming the v8 change has to go in at the same time?  

Right now it does a conversion at the interface between v8 and this code.  I
have the v8 patch ready to go as well, so I can make that change and then follow
up this one with updating DEPS + removing the thunk.

Expand Messages | Collapse Messages