Linux: Just enough toolbar theming to make everything look normal again....

Linux: Just enough toolbar theming to make everything look normal again.

http://crbug.com/11679


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16339

[Dean McNamee, 2009-05-18 16:20:23]

The massive additional NineBox constructor is kind of a bummer.

http://codereview.chromium.org/115438/diff/1/3
File chrome/browser/gtk/browser_toolbar_gtk.cc (right):

http://codereview.chromium.org/115438/diff/1/3#newcode323
Line 323: // We would want to pass |e->area.y| rather than 0, but the toolbar is
"We would want" sounds strange, since, apparently, it is not what we would want.

[Evan Stade, 2009-05-18 16:28:45]

On 2009/05/18 16:20:23, Dean McNamee wrote:
> The massive additional NineBox constructor is kind of a bummer.

I think that eventually we'll get rid of the old constructor, if that's any
consolation. 

> 
> http://codereview.chromium.org/115438/diff/1/3
> File chrome/browser/gtk/browser_toolbar_gtk.cc (right):
> 
> http://codereview.chromium.org/115438/diff/1/3#newcode323
> Line 323: // We would want to pass |e->area.y| rather than 0, but the toolbar
is
> "We would want" sounds strange, since, apparently, it is not what we would
want.

fixed.

[Evan Martin, 2009-05-18 22:40:09]

LGTM

[Lei Zhang, 2009-05-19 00:59:36]

This is triggering some leaks in valgrind:

http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20UI%203%20of...

Can you take a look?

[Evan Stade, 2009-05-19 01:03:43]

On 2009/05/19 00:59:36, Lei Zhang wrote:
> This is triggering some leaks in valgrind:
> 
>
http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20UI%203%20of...
> 
> Can you take a look?

yea, that looks to be an easy fix. I'll make a note to do it soon.