Issue 115423: - Fix numeric overflow handling when compiling count operations....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115423: - Fix numeric overflow handling when compiling count operations.... (Closed)

Created:
11 years, 7 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Kevin Millikin (Chromium), Kasper Lund, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Fix numeric overflow handling when compiling count operations. In certain situations the overflow checking corrupted the value being calculated. Committed: http://code.google.com/p/v8/source/detail?r=1978

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		3 chunks	+10 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

iposva

TRB= kasperl | ager | kmillikin http://codereview.chromium.org/115423/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/115423/diff/1/2#newcode118 Line 118: #ifdef DEBUG ...

11 years, 7 months ago (2009-05-15 22:35:14 UTC) #1

Good catch.  LGTM.

Expand Messages | Collapse Messages