ScriptController.* needs to be reformatted into WebKit style....

ScriptController.* needs to be reformatted into WebKit style.

TEST=Scripting in the browser. This should be pretty well covered by other testing.
BUG=http://crbug.com/12063



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16315

[levin, 2009-05-16 00:41:57]

I removed that np function stuff.  For some reason it seems completely unused
because everything built without it.  I'm doing a clean build right now just to
verify that.

[dglazkov, 2009-05-18 17:59:47]

LGTM -- I am assuming we'll have to refactor BindToWindowObject in a separate
pass. Perhaps a FIXME for it?

http://codereview.chromium.org/115417/diff/1007/8
File webkit/port/bindings/v8/ScriptController.h (right):

http://codereview.chromium.org/115417/diff/1007/8#newcode37
Line 37: #include "v8.h"
<v8.h>

http://codereview.chromium.org/115417/diff/1007/8#newcode59
Line 59: typedef v8::Persistent<v8::Value> JSResult;
Are these still being used?

http://codereview.chromium.org/115417/diff/1007/8#newcode96
Line 96: void BindToWindowObject(Frame*, const String& key, NPObject*);
bindToWindowObject -- this will require massive changes, wouldn't it :-\?

http://codereview.chromium.org/115417/diff/1007/8#newcode113
Line 113: //                           JSRootObject* rootObject);
We should probably just nix this.

[levin, 2009-05-18 20:30:12]

All fixed including renaming BindToWindowObject to bindToWindowObject which I
just missed before.


On 2009/05/18 17:59:47, Dimitri Glazkov wrote:
> LGTM -- I am assuming we'll have to refactor BindToWindowObject in a separate
> pass. Perhaps a FIXME for it?
> 
> http://codereview.chromium.org/115417/diff/1007/8
> File webkit/port/bindings/v8/ScriptController.h (right):
> 
> http://codereview.chromium.org/115417/diff/1007/8#newcode37
> Line 37: #include "v8.h"
> <v8.h>
> 
> http://codereview.chromium.org/115417/diff/1007/8#newcode59
> Line 59: typedef v8::Persistent<v8::Value> JSResult;
> Are these still being used?
> 
> http://codereview.chromium.org/115417/diff/1007/8#newcode96
> Line 96: void BindToWindowObject(Frame*, const String& key, NPObject*);
> bindToWindowObject -- this will require massive changes, wouldn't it :-\?
> 
> http://codereview.chromium.org/115417/diff/1007/8#newcode113
> Line 113: //                           JSRootObject* rootObject);
> We should probably just nix this.

[dglazkov, 2009-05-18 20:35:35]

LGTM.