Issue 115402: Reduced malloc/free operations in the parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115402: Reduced malloc/free operations in the parser. (Closed)

Created:
11 years, 7 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund, Kevin Millikin (Chromium), Kevin Millikin (Google)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reduced malloc/free operations in the parser. Committed: http://code.google.com/p/v8/source/detail?r=1969

Patch Set 1 #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -44 lines)			Patch
	M	src/jump-target.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/parser.cc	View		12 chunks	+93 lines, -43 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM! http://codereview.chromium.org/115402/diff/1/3 File src/parser.cc (right): http://codereview.chromium.org/115402/diff/1/3#newcode58 Line 58: class Element { Couldn't the entire Element ...

11 years, 7 months ago (2009-05-15 13:37:11 UTC) #2

LGTM.

Expand Messages | Collapse Messages