Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 115401: Introduce compact version of debugger response (Closed)

Created:
11 years, 7 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

If 'compactFormat' argument is passed in the request the response won't include referenced mirrors in the refs section instead each protocol reference object will contain some details necessary for displaying the referenced object in the graphical debugger when the object is not expanded. That allows to request full information lazily when the object is expanded. Committed: http://code.google.com/p/v8/source/detail?r=1977

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -8 lines) Patch
M src/debug-delay.js View 2 chunks +7 lines, -0 lines 0 comments Download
M src/mirror-delay.js View 1 3 chunks +62 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
11 years, 7 months ago (2009-05-15 13:08:27 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/115401/diff/1/2 File src/mirror-delay.js (right): http://codereview.chromium.org/115401/diff/1/2#newcode1790 Line 1790: o.value = mirror.value(); How about using the ...
11 years, 7 months ago (2009-05-15 14:48:01 UTC) #2
yurys
11 years, 7 months ago (2009-05-15 15:49:05 UTC) #3
http://codereview.chromium.org/115401/diff/1/2
File src/mirror-delay.js (right):

http://codereview.chromium.org/115401/diff/1/2#newcode1790
Line 1790: o.value = mirror.value();
On 2009/05/15 14:48:01, Søren Gjesse wrote:
> How about using the property name 'text', and yust using toText for all types.
> With this approach a long string will still cause a large response.

Done for strings. We cannot afford this for all types because some mirrors have
toText returning already beutified values and we want to have control over the
formatting in the UI.

Powered by Google App Engine
This is Rietveld 408576698