Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 11540: Fixes bug where tooltips would get stuck. This was happening because... (Closed)

Created:
12 years, 1 month ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixes bug where tooltips would get stuck. This was happening because on Vista we manage showing/hiding tooltips ourself. It would appear when managing our own tooltips like this we need to explicitly hide the tooltip. If you rapidly moved the mouse we wouldn't get a mouse move and the tooltip would stick. The fix is to have ContainerWin forward mouse leave and have the tooltip manager close the tooltip on mouse leave. BUG=2717 TEST=on vista do the following. Add a bookmark to the bookmark bar and hover the mouse over it. Then hit control-b so the bookmark bar disappears. Make sure the tooltip disappears too. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/views/aero_tooltip_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/views/aero_tooltip_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/views/container_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/views/tooltip_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
12 years, 1 month ago (2008-11-20 20:55:14 UTC) #1
Glen Murphy
12 years, 1 month ago (2008-11-20 22:34:30 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698