Issue 115397: DevTools: Introduce lightweight version of JSON serialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115397: DevTools: Introduce lightweight version of JSON serialization. (Closed)

Created:
11 years, 7 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Introduce lightweight version of JSON serialization. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16153

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -12 lines)			Patch
M	base/json_writer.h	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	base/json_writer.cc	View	1	6 chunks	+29 lines, -10 lines	0 comments	Download
M	webkit/glue/devtools/devtools_rpc.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

11 years, 7 months ago (2009-05-15 09:23:39 UTC) #2

LGTM

http://codereview.chromium.org/115397/diff/1/2
File base/json_writer.cc (right):

http://codereview.chromium.org/115397/diff/1/2#newcode15
Line 15: void JSONWriter::Write(const Value* const node,
Write and WriteNoEscape are almost identical, please extract common code into a
method or you could use 'noescape' parameter with default value

http://codereview.chromium.org/115397/diff/1/2#newcode33
Line 33: json->reserve(1024);
can you leave that to the caller as some clients won't need that big buffer?

Expand Messages | Collapse Messages