Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 115397: DevTools: Introduce lightweight version of JSON serialization. (Closed)

Created:
11 years, 7 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

DevTools: Introduce lightweight version of JSON serialization. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16153

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -12 lines) Patch
M base/json_writer.h View 1 1 chunk +9 lines, -1 line 0 comments Download
M base/json_writer.cc View 1 6 chunks +29 lines, -10 lines 0 comments Download
M webkit/glue/devtools/devtools_rpc.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
11 years, 7 months ago (2009-05-15 09:07:31 UTC) #1
yurys
11 years, 7 months ago (2009-05-15 09:23:39 UTC) #2
LGTM

http://codereview.chromium.org/115397/diff/1/2
File base/json_writer.cc (right):

http://codereview.chromium.org/115397/diff/1/2#newcode15
Line 15: void JSONWriter::Write(const Value* const node,
Write and WriteNoEscape are almost identical, please extract common code into a
method or you could use 'noescape' parameter with default value

http://codereview.chromium.org/115397/diff/1/2#newcode33
Line 33: json->reserve(1024);
can you leave that to the caller as some clients won't need that big buffer?

Powered by Google App Engine
This is Rietveld 408576698