Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 115361: Backport r16026 from the trunk to the 172 branch.... (Closed)

Created:
11 years, 7 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/branches/172/src/
Visibility:
Public.

Description

Backport r16026 from the trunk to the 172 branch. If Schannel's InitializeSecurityContext calls return certificate errors, do not map them to our (server) certificate errors because the errors are referring to the (missing) client certificate. If we incorrectly handle them as server certificate errors, we will crash because we can't get the server certificate from Schannel when the handshake fails. Fumitoshi Ukai of Google tracked down the bug and proposed an alternative fix. R=rvargas,mal BUG=http://crbug.com/11646 TEST=Visit https://www.cdep.ro/. Chromium should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M net/base/ssl_client_socket_win.cc View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
Mark, This changelist fixes a browser process crash. I'd like to backport this fix to ...
11 years, 7 months ago (2009-05-14 17:38:39 UTC) #1
rvargas (doing something else)
LGTM.
11 years, 7 months ago (2009-05-14 17:49:26 UTC) #2
Mark Larson
11 years, 7 months ago (2009-05-14 18:31:54 UTC) #3
OK

Powered by Google App Engine
This is Rietveld 408576698